-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to jump to a specific timestamp via bottom bar in editor #28511
Conversation
Apparently this is a stable feature and is helpful for modding.
To match stable there should be a few changes:
|
I've made this work although I'm not completely sold on the third thing being a thing. stable's timestamp parsing is very ad-hoc and hand-rolled so I did my own variant of it without looking at stable source because just glancing at it I don't trust it to be very robust or well-defined. |
I think your time stamp parser behaviour is pretty good. However I forgot to mention one case in stable which is important to have: If you input a single integer, e.g. |
Apparently this is a stable feature and is helpful for modding / dealing with timestamps outside of web.
2024-06-17.17-08-48.mp4